add timezone and datetime formatting on workspace member level #5699
+774
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODOs/FIXMEs:
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added timezone and datetime formatting fields to
WorkspaceMembertype in GraphQL - Introduced
DateTimeSettingscomponent for user-specific datetime preferences - Refactored and moved timezone and datetime utilities to
workspace-membermodule - Deleted redundant components and constants related to datetime settings
- Updated mock data to include new timezone and datetime formatting properties
packages/twenty-front/src/modules/settings/profile/components/DateTimeSettings.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/workspace-member/utils/detectTimeFormat.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/workspace-member/utils/formatDateLabel.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/workspace-member/utils/formatTimeLabel.ts
Outdated
Show resolved
Hide resolved
AdityaPimpalkar
commented
Jun 2, 2024
...ty-server/src/modules/workspace-member/standard-objects/workspace-member.workspace-entity.ts
Outdated
Show resolved
Hide resolved
martmull
reviewed
Jun 3, 2024
packages/twenty-front/src/modules/workspace-member/utils/formatDateLabel.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/workspace-member/utils/formatDateLabel.ts
Outdated
Show resolved
Hide resolved
...ty-server/src/modules/workspace-member/standard-objects/workspace-member.workspace-entity.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/user/dtos/workspace-member.dto.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/workspace-member/constants/TimeFormat.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/workspace-member/constants/TimeFormat.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/workspace-member/constants/DateFormat.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Introduced timezone and datetime formatting at the workspace member level
- Updated GraphQL queries and mutations to use new
DateFormatandTimeFormatenums - Enhanced
DateTimeSettings.tsxfor granular control over date and time settings - Added new fields and enums for timeZone, dateFormat, and timeFormat in
workspace-member.dto.ts - Updated
workspace-member.workspace-entity.tsto define and use new enums for date and time formats
| @@ -34,7 +34,7 @@ export const Elipsis: Story = { | |||
|
|
|||
| export const Performance = getProfilingStory({ | |||
| componentName: 'DateTimeFieldDisplay', | |||
| averageThresholdInMs: 0.1, | |||
| averageThresholdInMs: 0.2, | |||
There was a problem hiding this comment.
TODO: check - if we merge like this we need to be sure there isn't a better solution
There was a problem hiding this comment.
It is okay to increase if we don't have the choice but in that case you have to "proof" that you've understood the reason why it was increasing and why we can't do any better
There was a problem hiding this comment.
Memoizing the function outside of react scope did the job! Now its running under 0.1ms 👍
packages/twenty-front/src/modules/settings/profile/components/DateTimeSettings.tsx
Outdated
Show resolved
Hide resolved
...ty-server/src/modules/workspace-member/standard-objects/workspace-member.workspace-entity.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/profile/components/DateTimeSettings.tsx
Outdated
Show resolved
Hide resolved
| setTimeZone, | ||
| TimeFormat.STANDARD, | ||
| )})`, | ||
| value: TimeFormat.STANDARD, |
There was a problem hiding this comment.
How come 12 hours is "standard" 😁. We use 24hours in France ;)
There was a problem hiding this comment.
haha, I agree the naming is a little confusing here, its the "format" for time here which is "standard" if that makes sense. Whichever timezone is detected it will set it automatically to that "format" for that respective timezone
packages/twenty-front/src/modules/workspace-member/utils/formatDateLabel.ts
Show resolved
Hide resolved
AdityaPimpalkar
commented
Jul 2, 2024
Comment on lines
+60
to
+72
| const handleSettingsChange = ( | ||
| settingName: 'timeZone' | 'dateFormat' | 'timeFormat', | ||
| value: string, | ||
| ) => { | ||
| const workspaceMember: any = {}; | ||
| const dateTime: any = {}; | ||
|
|
||
| switch (settingName) { | ||
| case 'timeZone': { | ||
| workspaceMember[settingName] = value; | ||
| dateTime[settingName] = value === 'system' ? detectTimeZone() : value; | ||
| break; | ||
| } |
There was a problem hiding this comment.
Tried something different here to call setDateTimeFormat once, open for suggestions :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5140